debugger: wait for V8 debugger to be enabled#38811
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
debugger: wait for V8 debugger to be enabled#38811targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
added
inspector
Member
Author
|
@nodejs/inspector This is probably not entirely fixed ( |
aduh95
approved these changes
May 26, 2021
Collaborator
aduh95
added
author ready
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
richardlau
approved these changes
May 26, 2021
BethGriggs
approved these changes
May 26, 2021
Flarna
approved these changes
May 26, 2021
bl-ue
approved these changes
May 26, 2021
Collaborator
Trott
approved these changes
May 26, 2021
Collaborator
Member
Author
|
CI is blocked on #38820 |
Collaborator
Collaborator
Collaborator
targos
added a commit
that referenced
this pull request
May 28, 2021
Refs: #38273 (comment) PR-URL: #38811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in f1cbaea |
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
Refs: #38273 (comment) PR-URL: #38811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Member
|
Doesn't land cleanly on v14.x-staging. |
Member
It will land cleanly if you land #38411 and #38406 first, both of which will cherry-pick cleanly to v14.x-staging (at least if they are cherry-picked in that order). I know you're skipping the primordials stuff generally for v14.x-staging, but maybe you would be OK making an exception for |
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 19, 2021
Refs: nodejs#38273 (comment) PR-URL: nodejs#38811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Backport to v14.x PR: #39446 |
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 20, 2021
Refs: nodejs#38273 (comment) PR-URL: nodejs#38811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 20, 2021
Refs: nodejs#38273 (comment) PR-URL: nodejs#38811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 22, 2021
Refs: #38273 (comment) PR-URL: #38811 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 22, 2021
Refs: #38273 (comment) PR-URL: #38811 Backport-PR-URL: #39446 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Refs: nodejs#38273 (comment) PR-URL: nodejs#38811 Backport-PR-URL: nodejs#39446 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #38273 (comment)